feat: ER diagram: allow other chars in a quoted entity name

[weedySeaDragon]

📑 Summary

In an ER diagram, if the entity name is surrounded by double quotes, punctuation, spaces, and other non alpha-numeric characters are now allowed.

Ex:

Resolves #3171 (This issue has a number of up-votes)

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

1. If an entity name is surrounded by double quotes (") then it can contain all characters EXCEPT:

   • % (because that might make parsing comments harder)
   • "
   • line feeds (\n and \r)
   • vertical feed character (\v)
   • backspace (\b)

   The regex used erDiagram.jison for an entity name is quotes is:
   \"[^"%\r\n\v\b\\]+\"

   (We're still limited by what jison will allow.)

   Q: Are there other characters that should be excluded?

2. The diagram renderer (erRenderer.js) creates elements and graph items based on the entity name. This needed to be changed since there can now be entity names that are not valid XML ids.

   • generate a unique id for each entity based loosely on the (sanitized) name + a uuid
   • keep a Map so that entities can be looked up by either name or (new) id

(I decided to dive into the code via the ER diagram. The code is small. Now that I understand it, I can work on other ER diagram issues.)

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added unit/e2e tests (if appropriate)
• 🔖 targeted develop branch
• 📝 update the documentation if/when approved

[knsv]

You are doing good work! @weedySeaDragon If you want to join the core team of Mermaid contact me on slack (knsv)

[knsv]

@weedySeaDragon Which version of er.html did you want to keep? I am keeping what is coming in the PR, did yo want anything else?

[weedySeaDragon]

@knsv It would be good to put in an accessible title in this er.html as well:
I can do that in a separate PR if that's easiest.
(Didn't know what order these PRs would be merged)