Fix failing vitest unit tests

[aloisklink]

📑 Summary

Fix the failing vitest unit tests.

I think this was broken by #3557

It looks like dependabot doesn't support pnpm, and because of that, it's PRs don't work very well, see dependabot/dependabot-core#1736

Maybe it's worth switching to use npm workspaces instead? It'll probably be slower, but it will mean we won't get dependabot issues.

📏 Design Decisions

Removes vitest from all subpackages so that vitest/pnpm run test are only in the root mono-repo.

This is required, because otherwise the root vitest and the subpackage vitest versions can be slightly different, which causes issues when running unit tests:

Error: Snapshot cannot be used outside of test

Potential future improvement

In the future, we may want to consider moving package specific tests into packages/*/test, and instead running these tests with pnpm run --recursive, so that tests are run in each package by their own version of vitest. This is the way that most projects do things (e.g. https://github.com/vitest-dev/vitest).

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added unit/e2e tests (if appropriate)
• 🔖 targeted develop branch

[sidharthv96]

Re: dependabot, a better option would be to use Renovate, which we're using in live editor and also by the svelte team in their monorepo.

[sidharthv96]

Shouldn't we add the options mentioned here if we're removing the imports?

https://vitest.dev/config/#globals

[aloisklink]

Both are already added on the develop branch!

mermaid/vite.config.ts

Line 11 in b1540d1

globals: true,

mermaid/tsconfig.json

Lines 37 to 39 in b1540d1

	"types": [
	"vitest/globals"
	] /* Specify type package names to be included without being referenced in a source file. */,

I think that's what was causing the issues.

The global: true was loading vitest from node_modules/vitest.
But the import {...} from "vitest"; was loading vitest from packages/mermaid/node_modules/vitest (and because of dependabot, this were different versions of vitest). Because of that, only the limited files with import {} from "vitest"; were failing.