-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with generic class not rendering #5098
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #5098 +/- ##
===========================================
- Coverage 79.41% 77.12% -2.30%
===========================================
Files 166 166
Lines 13871 13873 +2
Branches 705 705
===========================================
- Hits 11016 10699 -317
- Misses 2703 3015 +312
- Partials 152 159 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some unit tests? Added.
📑 Summary
Updated addClassesToNamespace function to split the classname/type to ensure correct item is being assigned to namespace
Resolves #4578