feat: add name field to the actors #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5284 +/- ##
========================================
Coverage 79.14% 79.15%
========================================
Files 175 175
Lines 14512 14516 +4
Branches 866 867 +1
========================================
+ Hits 11486 11490 +4
Misses 2823 2823
Partials 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@sidharthv96 friendly reminder :) |
|
Any update on this PR? |
|
Was really busy. This should be out in 10.9.0 soon. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Awesome thanks @sidharthv96 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
namefield to the actors for easier identification in SVG nodes.sequence.htmlcc @sidharthv96
📏 Design Decisions
The final goal is to make the overall API better as mentioned in #5017 (comment), this is an alternative to get the attributes easily from
svgsince right now there is no way to identify both actor nodes belonging to one particular actor as there is no unique identifier. Hence I am adding anameidentifier so the nodes can be identified in SVG easily as well.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch