Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for intersection issue #6038

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Nov 8, 2024

📑 Summary

Intersection calculations for tilted cylinder/DAS when using handdrawn look will break for some random seeds could cause the calculations to break.

Resolves #6037

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 1388662

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 1388662
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/672e0d6634c4f9000815893b
😎 Deploy Preview https://deploy-preview-6038--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@6038
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6038
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6038
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6038

commit: 1388662

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (c218e36) to head (1388662).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...g-util/rendering-elements/shapes/tiltedCylinder.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6038   +/-   ##
=======================================
  Coverage     4.49%   4.49%           
=======================================
  Files          383     383           
  Lines        53925   53925           
  Branches       596     596           
=======================================
  Hits          2425    2425           
  Misses       51500   51500           
Flag Coverage Δ
unit 4.49% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g-util/rendering-elements/shapes/tiltedCylinder.ts 0.00% <0.00%> (ø)

Copy link

argos-ci bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Nov 8, 2024, 1:19 PM

Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch!

@aloisklink aloisklink added this pull request to the merge queue Nov 8, 2024
Merged via the queue into develop with commit c8ce416 Nov 8, 2024
26 checks passed
@aloisklink aloisklink deleted the fix-for-tilted-cylinder-intersect branch November 8, 2024 13:37
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intersection calculations for tilted cylinder/DAS when using handdrawn look will break for some random seeds
2 participants