Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use layout-elk in example.html #6055

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

agokhale
Copy link
Contributor

📑 Summary

dev playground dies looking for these imports
Resolves #

📏 Design Decisions

don't import the broken thing tha

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 4e17da0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 4e17da0
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6746e7f5874d580008fb9b6c
😎 Deploy Preview https://deploy-preview-6055--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6055
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6055
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6055
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6055

commit: 4e17da0

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.49%. Comparing base (c8ce416) to head (4e17da0).
Report is 16 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6055   +/-   ##
=======================================
  Coverage     4.49%   4.49%           
=======================================
  Files          383     383           
  Lines        53925   53925           
  Branches       596     596           
=======================================
  Hits          2425    2425           
  Misses       51500   51500           
Flag Coverage Δ
unit 4.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@agokhale
Copy link
Contributor Author

f135a3a <-- original commit introducing bug is ??

Copy link

argos-ci bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

@agokhale
Copy link
Contributor Author

@sidharthv96 ^^ can you take this please in reference to your previous commit. f135a3a

@sidharthv96 sidharthv96 changed the title the ELK imports break the dev playground, drop them Use layout-elk in example.html Nov 27, 2024
@sidharthv96
Copy link
Member

The playground is broken because we deprecated the package, and moved to mermaid-layout-elk. I've updated it now. Thanks for bringing it up.

@sidharthv96 sidharthv96 merged commit 95964b5 into mermaid-js:develop Nov 27, 2024
14 of 15 checks passed
Copy link

mermaid-bot bot commented Nov 27, 2024

@agokhale, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants