Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uml and remove hard-coded styles #725

Closed

Conversation

TakenPilot
Copy link

Hi,

I'm using mermaid for a new site that I'm making that will be highly focused on software design. However, there were two features that didn't work as I expected, so I changed them. I'm submitting a PR here in case you want the changes too.

  1. Firstly, there was hard-coded CSS setting the font to whatever was auto-detected in the browser. This is fairly fragile. I don't know why it was added, but it's probably an edge case or a "compatibility" thing. I don't think anyone would expect this sort of feature, and it was surprising.

It was also causing problems when the font loads slowly on the page, randomly. It also failed if I did anything different with font-size. I really recommend leaving the users alone with their choice of font. 😁

  1. The classes were mixed up or missing from the UML diagrams. I fixed this, and now everything looks great.

Also: I noticed that some of the features being tested in the UML diagrams don't actually do anything, but they're also not failing. I'm guessing they were features that aren't finished yet? Can I help?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 689

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 54.334%

Totals Coverage Status
Change from base Build 671: 0.05%
Covered Lines: 2053
Relevant Lines: 3754

💛 - Coveralls

@@ -122,10 +122,11 @@ describe('class diagram, ', function () {
expect(relations[0].relation.type1).toBe(classDb.relationType.EXTENSION)
expect(relations[0].relation.type2).toBe('none')
expect(relations[0].relation.lineType).toBe(classDb.lineType.LINE)
console.log(relations)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.

@tylerlong
Copy link
Collaborator

Firstly, there was hard-coded CSS setting the font to whatever was auto-detected in the browser.

This is for portability. After the graph is generated, people might copy and use it somewhere else. Inline the CSS could make it look the same everywhere. I know it has issues, but I don't have solution, unfortunately.

Also: I noticed that some of the features being tested in the UML diagrams don't actually do anything, but they're also not failing. I'm guessing they were features that aren't finished yet? Can I help?

Class diagram is experimental feature which is not finished. The original author has stopped working on this project. You are welcome to contribute.

@DanShai
Copy link
Contributor

DanShai commented Feb 16, 2019

Class diagram is experimental feature which is not finished. The original author has stopped working on this project. You are welcome to contribute.

I did a PR for this issue in here #795

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Type: New Shape Request for new shape label Jun 29, 2019
@github-actions github-actions bot closed this Sep 24, 2019
mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
…yarn/develop/daisyui-2.13.5

chore(deps): bump daisyui from 2.13.0 to 2.13.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Shape Request for new shape
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants