-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix uml and remove hard-coded styles #725
fix uml and remove hard-coded styles #725
Conversation
Pull Request Test Coverage Report for Build 689
💛 - Coveralls |
@@ -122,10 +122,11 @@ describe('class diagram, ', function () { | |||
expect(relations[0].relation.type1).toBe(classDb.relationType.EXTENSION) | |||
expect(relations[0].relation.type2).toBe('none') | |||
expect(relations[0].relation.lineType).toBe(classDb.lineType.LINE) | |||
console.log(relations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed.
This is for portability. After the graph is generated, people might copy and use it somewhere else. Inline the CSS could make it look the same everywhere. I know it has issues, but I don't have solution, unfortunately.
Class diagram is experimental feature which is not finished. The original author has stopped working on this project. You are welcome to contribute. |
I did a PR for this issue in here #795 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…yarn/develop/daisyui-2.13.5 chore(deps): bump daisyui from 2.13.0 to 2.13.5
Hi,
I'm using mermaid for a new site that I'm making that will be highly focused on software design. However, there were two features that didn't work as I expected, so I changed them. I'm submitting a PR here in case you want the changes too.
It was also causing problems when the font loads slowly on the page, randomly. It also failed if I did anything different with font-size. I really recommend leaving the users alone with their choice of font. 😁
Also: I noticed that some of the features being tested in the UML diagrams don't actually do anything, but they're also not failing. I'm guessing they were features that aren't finished yet? Can I help?