Fix text label colors for flow charts #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knsv Is there a way to set the color based on the |
When htmlLabels is set to `false` and a background fill color is used for a node, the text label will inherit the fill color, hiding the actual text. To fix this, explicitly set the fill color to `mermaid-js#333`, the same value used in `src/themes/flowchart.scss`. Closes mermaid-js#885
stanhu
force-pushed
the
sh-fix-flowchart-label
branch
from
11b8297
to
83b7163
Compare
|
You can style that in css using something like this. .label text { fill: red}Maybe you could update your pull request to fix the issue that way? |
|
Oh, thanks! That works much better. |
stanhu
force-pushed
the
sh-fix-flowchart-label
branch
from
745970c
to
c6502fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When htmlLabels is set to
falseand a background fill color is usedfor a node, the text label will inherit the fill color, hiding the
actual text. To fix this, explicitly set the fill color to
#333in the SCSS.Closes #885