This repository has been archived by the owner on Jul 22, 2023. It is now read-only.
Scaling <svg> root to fit browser window - fix #3 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. But I need to do some manual test before I can merge it. |
|
No problem :) |
|
Finally I have some time to test it. It works for PNG files. But it has no effect for svg (I know svg is scalable but it's ideal to change the default size.) It behaves strangely for pdf files. Another concern is by default mermaid will choose a "proper" size if the page is too wide. This PR will break it, so user has to specify a proper width manually every time. |
|
Overall this should be a mermaid issue. Mermaid doesn't allow user to manually set a width for the charts. It figures out the width according to page width and it also doesn't always take 100% of the page width. Feel free to create an issue for the mermaid project. I will close this PR now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not a commander flag because I think it is always preferable to have a transparent background
What do you think ?