Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

Improve ux of account commands #100

Merged
merged 6 commits into from
Jul 8, 2019
Merged

Improve ux of account commands #100

merged 6 commits into from
Jul 8, 2019

Conversation

NicolasMahe
Copy link
Member

No description provided.

antho1404
antho1404 suggested changes Jul 8, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not add new logs and use the spinner as it was

krhubert
krhubert reviewed Jul 8, 2019
View reviewed changes
src/account-command.ts Outdated Show resolved Hide resolved
src/commands/account/import.ts Outdated Show resolved Hide resolved
Nicolas Mahé and others added 2 commits July 8, 2019 16:33
@NicolasMahe
Copy link
Member Author

let's not add new logs and use the spinner as it was

updated

@antho1404 antho1404 merged commit 5811ced into master Jul 8, 2019
@antho1404 antho1404 deleted the ux/command-account branch July 8, 2019 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krhubert krhubert krhubert left review comments

@antho1404 antho1404 antho1404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasMahe @antho1404 @krhubert