This repository has been archived by the owner on Nov 14, 2019. It is now read-only.
implement new service start command #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
under temporary service:newstart name.
|
Can you fix the conflicts and make sure the checks are green |
antho1404
reviewed
Jun 6, 2019
|
waiting on grpc apis to finalise before adding any more commits to this pr |
ilgooz
force-pushed
the
feature/new-start
branch
from
af89992
to
aab9ace
Compare
ilgooz
force-pushed
the
feature/new-start
branch
from
aab9ace
to
8a57d0b
Compare
antho1404
reviewed
Jun 17, 2019
|
|
||
| import Command from '../../service-command' | ||
|
|
||
| export default class ServiceDeployNew extends Command { |
There was a problem hiding this comment.
Maybe this should be named differently, ServiceStartNew, InstanceCreate...
There was a problem hiding this comment.
when previous start cmd removed, this one will get its name. there is no reason to perfect the name of this temp cmd
Co-Authored-By: Anthony <anthony@mesg.com>
|
closing in favor of #81 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
under temporary service:start name.
depends on #44