-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fixed the modal screen fit issue w/signoff #1805
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test for mobile screens as I can see it's not working perfectly fine!
I checked for mobile screens, height wise they work fine but width wise they're cut-off, is that the issue you are talking about? @Ashparshp |
When you scroll it check for buttons they don't fit! |
Does this look fine? @Ashparshp |
@kanishk6103 |
sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But why are you creating so many commits? It seems like there are a lot of empty ones.
I am really sorry for that, when I commited the responsive behaviour of buttons I forgot to sign it, so I had to rebase which made a lot of commits. Other than that, the master branch was being updated so I was updating my branch which again created a bit more commits. I am sorry for that. |
@kanishk6103, you've created 20 commits? |
I did not mean to create them, as I said I forgot to sign, so I had to rebase and sign the previous ones, that created commits, rest are me updating my branch to the latest ones. Again, I am sorry for this, what should I do? @Ashparshp |
@kanishk6103, no worries at all! These things happen.... I was just reminding you in case you missed it. You can also ignore this for now... No sweat 😅. Keep up the good work! |
Also, If you want to clean up the commit history, you can squash your commits into one. This will help keep the history neat... |
Hey! I think i should raise a new PR, this one is a bit messed up. |
I have created a new PR for this: #1859 |
Description
This PR fixes #1803
Notes for Reviewers
Signed commits