Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Adafruit Feather RP2040 with RFM95. #4451

Conversation

miltieIV2
Copy link
Contributor

Thank you for sending in a pull request, here's some tips to get started!

(Please delete all these tips and replace with your text)

  • Before starting on some new big chunk of code, it it is optional but highly recommended to open an issue first
    to say "hey, I think this idea X should be implemented and I'm starting work on it. My general plan is Y, any feedback
    is appreciated." This will allow other devs to potentially save you time by not accidentially duplicating work etc...
  • Please do not check in files that don't have real changes
  • Please do not reformat lines that you didn't have to change the code on
  • We recommend using the Visual Studio Code editor along with the 'Trunk Check' extension (In beta for windows, WSL2 for the linux version),
    because it automatically follows our indentation rules and its auto reformatting will not cause spurious changes to lines.
  • If your PR fixes a bug, mention "fixes #bugnum" somewhere in your pull request description.
  • If your other co-developers have comments on your PR please tweak as needed.
  • Please also enable "Allow edits by maintainers".

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@miltieIV2
Copy link
Contributor Author

See #4405

@miltieIV2
Copy link
Contributor Author

Move meshtastic_HardwareModel enum 72 -> 75

@miltieIV2
Copy link
Contributor Author

CLA signed

dropping this change from the file generated by the protobuf
remove these reverting changes
oops, missed a comma
@miltieIV2
Copy link
Contributor Author

Opened protobuf PR: meshtastic/protobufs#559

@miltieIV2
Copy link
Contributor Author

Comment added to protobuf PR: meshtastic/protobufs#559

This is the first platform.io Adafruit Feather RP2040 board.
There is a of course a lot of pin overlap with other RP2040, but this is the first USE_RF95 RP2040.

@miltieIV2
Copy link
Contributor Author

Waiting on: meshtastic/protobufs#559

@miltieIV2
Copy link
Contributor Author

I'm used to seeing the green merge button.
What happens next?

@thebentern thebentern merged commit 777ae2b into meshtastic:master Aug 26, 2024
101 checks passed
geeksville pushed a commit to geeksville/Meshtastic-esp32 that referenced this pull request Aug 28, 2024
* Add support for Adafruit Feather RP2040 with RFM95.

* Update mesh.pb.h

dropping this change from the file generated by the protobuf

* Update mesh.pb.h

remove these reverting changes

* Update mesh.pb.h

oops, missed a comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants