Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new port number for airborne application(s) #5281

Closed
wants to merge 3 commits into from

Conversation

pjalocha
Copy link

@pjalocha pjalocha commented Nov 8, 2024

I am very sorry, I forgot to actually change the name of the new port !
I fixed it in the next push to the same branch, but I am not sure how to proceed now.
Sorry for the mess.

I propose a new port number for airborne applications like OGN-Tracer or FANET or ADS-L whch have well establilshed compact position packet formats. It is more efficient to put position in this format, which takes like 16 bytes for OGN than use the GPS generic format where many elements are missing like climb rate ro turn rate.

The new port number would allow efficient (low rate) position reports by objects like amateur balloons.

The formatting would be simple: I define ID's for particulat packet type and they would be embedded as a pack of bytes, the decoding of the pack would follow the particular system.

If this gets accepted, I will proceed to define those ID's

Thank you.

BTW. I am beta-receiving Meshtantic on ground receivers of the Open Glider Network (OGN) and I wonder if it would be worth to upload this traffic to a server of yours ?

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gjelsoe
Copy link
Contributor

gjelsoe commented Nov 8, 2024

You need to make a PR to protobufs, portnums.pb.h is auto generated.

Copy link
Contributor

@fifieldt fifieldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @gjelsoe said, this change needs to be ade in the protobufs repo.

@pjalocha
Copy link
Author

pjalocha commented Nov 9, 2024

Thank you, I will make the changes, and push them.

@pjalocha
Copy link
Author

pjalocha commented Nov 9, 2024

I have done the hopefully correct now change in the meshtantic/protobufs and made a pull request there.
You might then remove this pull request and treat the other one.
Thank you.

fifieldt added a commit to fifieldt/meshtastic-protobufs that referenced this pull request Nov 10, 2024
Most of the GPS chips we support have the ability to change their
operating model "dynamics" based on the intended activities.

We currently assume everyone is a pedestrian and configure as such.

However, there are users out there on bikes, planes, balloons, and
with fixed devices. Where GPS chips support it, we can configure for
each of this circumstances and improve performance.

For example, fixed nodes might no longer jump around on the map.
Planes will have a more responsive and less filtered position.
Balloons' GPS won't simply cut out because its gone over an altitude
limit. Boats won't have altitudes that make them appear to be floating
in the air.

Additionally, this could provide the opportunity for a bit of fun
in the apps - surface information about the use case so people know
when they're connecting to a plane or baloon :)

Related to: meshtastic/firmware#3984
Related to: meshtastic#619
Related to: meshtastic/firmware#5281
@caveman99
Copy link
Member

this is a null change. closing in favor of protobuf PR's

@caveman99 caveman99 closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants