Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/pin requirements.txt versions #90

Merged
merged 2 commits into from
Oct 11, 2017
Merged

Update/pin requirements.txt versions #90

merged 2 commits into from
Oct 11, 2017

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 5, 2017

Includes #89 to confirm passes CI (it does).

The last commit is unique for this PR: 564b176.

@meshy
Copy link
Owner

meshy commented Oct 10, 2017

Was there a reason that this needed to change? I'd rather keep the versions in requirements.txt pinned to specific versions. (I'm surprised that pytz isn't pinned.)

Instead of removing the specific version from this, i'd be more comfortable with changing the version to something more recent.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 11, 2017

Main reason was to make sure it still works with the latest version whenever the CI runs, so we don't get any surprises when updating locally, and also to be able to use a more recent version for other projects.

But it's fine to pin both to the latest, and update from time to time. I've updated this PR.

@hugovk hugovk changed the title Unpin installed Requests version Update/pin requirements.txt versions Oct 11, 2017
@ghickman
Copy link
Collaborator

@meshy – you could enable something like dependabot or pyup for this project, depends if you want the overhead of updating requirements weekly.

@meshy
Copy link
Owner

meshy commented Oct 11, 2017

@hugovk @ghickman I'm happy to bump the requirements to the latest version at the moment, but I'm not keen on the idea of updating them regularly without a pressing reason. I think that rules out dependabot, as far as I can see.

Pyup is interesting though. A security update could seem like a reasonable justification for automating updates. I'll install it, and see what happens!

@meshy
Copy link
Owner

meshy commented Oct 11, 2017

@hugovk any chance you could rebase master into this so that I can merge the requirements changes?

If not, don't worry, I'll use #93 instead, but I prefer yours because you've pinned pytz.

EDIT: oops, I referenced #92 in the first version of this comment.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 11, 2017

@meshy Rebased.

@meshy
Copy link
Owner

meshy commented Oct 11, 2017

Thank you :)

@meshy meshy merged commit 131ec4e into meshy:master Oct 11, 2017
@hugovk hugovk deleted the unpin-requests branch October 11, 2017 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants