Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: adding marker and stricter warning checks #214

Merged
merged 4 commits into from
Nov 23, 2022
Merged

TST: adding marker and stricter warning checks #214

merged 4 commits into from
Nov 23, 2022

Conversation

henryiii
Copy link
Contributor

Adding a marker for the isolated build testing. You can turn off this with -m "not isolated" - might be useful for conda-forge, where isolated builds don't matter.

Making the tests a bit stricter, checking for warnings.

@henryiii
Copy link
Contributor Author

Nice, only warning made error is DeprecationWarning: check_home argument is deprecated and ignored. - which I fixed a couple of days after CPython 3.11.0 shipped. Since it's in tests and just CPython triggering a warning on itself, should be fine to just to hide.

@henryiii henryiii marked this pull request as ready for review November 18, 2022 16:24
dnicolodi
dnicolodi requested changes Nov 20, 2022
View reviewed changes
Copy link
Member

@dnicolodi dnicolodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stricter warnings check may be worth adding, although having to silence warnings triggered by the Python standard library is very ugly. The test marking much less so, IMO.

tests/conftest.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@henryiii henryiii force-pushed the henryiii/tests/marker branch 3 times, most recently from dea588e to 00ad964 Compare November 21, 2022 15:36
@henryiii
Copy link
Contributor Author

Made changes, and updated history to be one commit per change. Also updated tmpdir to tmppath, since I noticed that elsewhere being py.path instead of pathlib - the first time I wrote this fixture, I wasn't able to use tmppath, but here it's fine.

@henryiii henryiii force-pushed the henryiii/tests/marker branch 3 times, most recently from f16135b to e8c6ca4 Compare November 21, 2022 15:58
@henryiii henryiii force-pushed the henryiii/tests/marker branch 2 times, most recently from 2e2e897 to a6a8399 Compare November 21, 2022 19:19
@henryiii @dnicolodi
STYLE: consistently use single quotes in pyproject.toml
2425e4f 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

fixup
@henryiii @dnicolodi
TST: stricter warning checks
cb5f1be 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii @dnicolodi
TST: clarify pep518 fixture does not need to be accessed
67f376c 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii @dnicolodi
TST: prefer tmp_path fixture to the tmpdir one
31012f4 
The former returns a pathlib.Path, the latter a py.path.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@dnicolodi dnicolodi merged commit d248adf into mesonbuild:main Nov 23, 2022
@henryiii henryiii mentioned this pull request Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnicolodi dnicolodi dnicolodi requested changes

@FFY00 FFY00 FFY00 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henryiii @dnicolodi @FFY00