CMake subproject with MSVC generate many warnings D9025

[SkyMaverick]

I use the CMake subproject in a project with cl-compiler and the ninja build system. The meson automatically puts the /ZI argument, but when parsing a subproject, it puts the /Zi argument. This causes many warnings D9025.

[xclaesse]

I think this is part of a bigger issue: We should pass to cmake all external args (e.g. cflags), especially when cross compiling, because cmake could need them to run its checks, etc. But then all those flags will end into the generated shared_library(c_args: ...) and meson will duplicate them all.

I think the solution is to add a new feature to Meson, shared_library(..., plain : true) where meson won't add any other compiler arguments.

[jpakkane]

Adding flags for people to workaround issues is not scalable. Making it work automatically is.

[xclaesse]

@jpakkane doesn't have to be part of meson's public API, could be an internal feature just for the cmake module. When I said shared_library(..., plain : true) it's not the user writing that, but the AST generated by cmake module.

[mensinda]

I don't think we need a specific feature for this. I would rather continue with the current argument blacklist approach and let meson handle those flags. Especially in this case where debug information is controlled. This is also how normal subprojects usually function unless the cargs are manually overwritten.

[mensinda]

@SkyMaverick Could you please upload (Pastebin, etc.) build/meson-logs/meson-log.txt and build/subprojects/<your subproject>/meson.build if it exists? This would help me identify where I have to blacklist flags.

[SkyMaverick]

@mensinda Done.
Used by libuv and libutf8proc as cmake-subprojects. meson-log.txt, libutf8proc meson.build, libuv meson.build.
Also uploaded build.ninja and ninja stdout, if need.

[mensinda]

Should be fixed with #6025.