Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_buildtype_args function #12575

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

@bruchar1 bruchar1 force-pushed the remove-get-buildtype-args branch from fa73e91 to a982b66 Compare December 2, 2023 00:47
@bruchar1 bruchar1 force-pushed the remove-get-buildtype-args branch from a982b66 to 677e04d Compare December 5, 2023 18:14
@jpakkane
Copy link
Member

Getting everything optimization and debug info related away from buildtype is a good thing. In fact I thought that is what we already did but apparently not.

I don't think we can deprecate buildtype for the reasons listed in the referred issue (it carries semantic meaning) so things like get_option('buildtype') have to keep working, possibly forever.

@dcbaker
Copy link
Member

dcbaker commented Dec 22, 2023

I like buildtype in some ways, but in others I don't. Really the only thing that I see being really useful is debug vs non-debug, and we already have a flag.

Could we at least start with deprecating -Dbuildtype and get_option('buildtype')? We'd need some patches from @bonzini's b_pie rework for the former, but the latter would be two lines of code in func_get_option(). That would at least get the ball rolling for the full removal whenever we're ready to have a 2.0 backwards incompatible change.

@jpakkane
Copy link
Member

Really the only thing that I see being really useful is debug vs non-debug, and we already have a flag

There needs to be some way of specifying the intent of "this build will be used for X". Trying to guess it from optimization flags or something is not reliable and if we don't provide this, every project will add their own which are different and won't work together.

@jpakkane
Copy link
Member

The question what to do with buildtype is unrelated to this MR, which is merely a refactoring. It should not block this.

@jpakkane jpakkane merged commit 4761e4c into mesonbuild:master Dec 23, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants