Improve the use of both_libraries #12632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruchar1
force-pushed
the
both-lib-deps
branch
from
c41f08e to
1a8115f
Compare
This was referenced Dec 14, 2023
bruchar1
force-pushed
the
both-lib-deps
branch
from
1a8115f to
b09c4b1
Compare
bruchar1
force-pushed
the
both-lib-deps
branch
2 times, most recently
from
f455e58 to
1682604
Compare
dcbaker
requested changes
Sep 5, 2024
bruchar1
force-pushed
the
both-lib-deps
branch
2 times, most recently
from
65d0fbe to
b8beae4
Compare
Otherwise, the both_libs object is resolved by the interpreter and we no longer have access to it from the dependency object.
bruchar1
force-pushed
the
both-lib-deps
branch
from
b8beae4 to
37de678
Compare
|
@dcbaker I think I addressed all your comments. typing in build.py is not easy, as this file is not ready for typing yet, so I didn't tried to run mypy on it... |
Yeah. Don't. I've tried to fix it several times and it's a huge amount of work to get it all right. I'm hoping to get back to it after I get the machinefile, options, and coredata done. |
|
I suspect this is breaking gobject-introspection when building GStreamer with default_library=both. |
|
The gnome module has a bunch of |
|
@dcbaker @bruchar1 This is causing GStreamer CI regression: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/7753. |
|
I'm not really setup for working with the gnome module. Would running the test (e.g. framework/7 gnome) with both_libraries trigger the bug? My guess is that calling Maybe should you open a separate issue to track this? |
|
I managed to write a unit test: #13835. |
xclaesse
added a commit
to xclaesse/meson
that referenced
this pull request
Oct 31, 2024
This partly reverts mesonbuild#12632 and provide an alternative implementation. The issue is we cannot propagate BothLibraries objects beyond the interpreter because it breaks many isinstance(obj, SharedLibrary) cases. Instead make SharedLibrary and StaticLibrary cross reference each other so we can take their brother library in as_static() and as_shared() methods.
xclaesse
added a commit
to xclaesse/meson
that referenced
this pull request
Oct 31, 2024
This partly reverts mesonbuild#12632 and provide an alternative implementation. The issue is we cannot propagate BothLibraries objects beyond the interpreter because it breaks many isinstance(obj, SharedLibrary) cases. Instead make SharedLibrary and StaticLibrary cross reference each other so we can take their brother library in as_static() and as_shared() methods.
xclaesse
added a commit
to xclaesse/meson
that referenced
this pull request
Nov 1, 2024
This partly reverts mesonbuild#12632 and provide an alternative implementation. The issue is we cannot propagate BothLibraries objects beyond the interpreter because it breaks many isinstance(obj, SharedLibrary) cases. Instead make SharedLibrary and StaticLibrary cross reference each other so we can take their brother library in as_static() and as_shared() methods.
xclaesse
added a commit
to xclaesse/meson
that referenced
this pull request
Nov 1, 2024
This partly reverts mesonbuild#12632 and provide an alternative implementation. The issue is we cannot propagate BothLibraries objects beyond the interpreter because it breaks many isinstance(obj, SharedLibrary) cases. Instead make SharedLibrary and StaticLibrary cross reference each other so we can take their brother library in as_static() and as_shared() methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #5452
as_staticandas_sharedmethods on dependencies for that (otherwise the default is automatically used)default_both_librariesto configure the default behavior of both_dependencies. Previously, it was always the shared version by default.In my monorepo, I need to compile static and shared versions of many common libs, for different uses. For instance, I usually prefer the shared version, but for plugins, I need to compile them with static dependencies to make them independent from the version of the common libs used in the main app. With the proposed changes, I can remove a lot of duplication in my build files, by using both_libraries instead of having to duplicate shared_library and static_library, along with their respective declare_dependency.