-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buildtype from debug and optimization #12699
base: master
Are you sure you want to change the base?
Conversation
d871b79
to
dd689df
Compare
dd689df
to
35b0b59
Compare
35b0b59
to
2e057b9
Compare
By adding a flag to indicate whether an option was explicitly set or not, it is now possible to update the value of `buildtype` from the values of `debug` and `optimization`, without modifying options that are explicitly set. Fixes mesonbuild#11645 Fixes mesonbuild#5814 (maybe this one was already fixed, but at least a test proves it works)
2e057b9
to
2fba5af
Compare
Remove warning about setting both buildtype and optimization or debug. This is no longer true, as you may want to change the optimization level but keep other behaviors derived from the buildtype.
2fba5af
to
dd9314b
Compare
FWICT the description means that if you set, for example, optimization to Buildtype is conceptually at a higher level than optimization and debug options. It means, roughly, "the current build setup will be used for purpose X, configure yourself accordingly". Resetting the latter to "expected defaults" when changing build type is reasonable and expected, whereas the opposite is not. If we were starting from scratch, then having a build dir set up for The way the documentation specifies things is not good and we should change it to this more sensible approach if we can get away with it without breaking backwards compatibility too much. |
The subtilty is that |
By adding a flag to indicate whether an option was explicitly set or not, it is now possible to update the value of
buildtype
from the values ofdebug
andoptimization
, without modifying options that are explicitly set.Fixes #11645
Fixes #10487
Fixes #5814 (maybe this one was already fixed, but at least a test proves it works)