Xcode backend: better quoting for spaces in HEADER_SEARCH_PATHS #13867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpakkane can you take a look at this one? I know you've blogged before about how much of a nightmare the xcode quoting rules are, so I'm afraid to merge this without your confirmation. :P |
klokik
force-pushed
the
xcode-fixes-2
branch
3 times, most recently
from
b36719c to
b61cc6d
Compare
|
Updated to cover other header paths in this array, split out path processing into a helper function to streamline the parent function a bit |
|
Thanks for mentioning the blog post, it was an interesting read indeed! |
Xcode treats this dict value as a space-separated string, any spaces in the path will make the path invalid by splitting it into pieces. Split out header path processing into a helper function.
klokik
force-pushed
the
xcode-fixes-2
branch
from
b61cc6d to
f889a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode treats this dict value as a space-separated string, any spaces in the path will invalidate the path by splitting it into pieces.
Xcode happens to be doing double quoting with escaping internal quotes for the case.