Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the use of get_option() as a parameter to project() #14011

Closed
wants to merge 0 commits into from

Conversation

bcorby
Copy link
Contributor

@bcorby bcorby commented Dec 16, 2024

Calling get_option() from within project() fails because the meson.options file hasn’t be read yet. Reading the options file from within func_get_option fixes the issue.

@bcorby bcorby force-pushed the test branch 4 times, most recently from b807efa to e4a3e96 Compare December 16, 2024 02:55
@bcorby bcorby changed the title Enable use of get_option in project statement Enable the use of get_option in project statement Dec 16, 2024
@bcorby bcorby changed the title Enable the use of get_option in project statement Enable the use of get_option() as a parameter for project() Dec 16, 2024
@bcorby bcorby force-pushed the test branch 3 times, most recently from 299826d to 911fdf4 Compare December 16, 2024 07:30
@bcorby bcorby force-pushed the test branch 8 times, most recently from 05aa763 to 064ff4c Compare December 16, 2024 09:10
@bcorby bcorby changed the title Enable the use of get_option() as a parameter for project() Enable the use of get_option() as a parameter to project() Dec 16, 2024
@bcorby bcorby force-pushed the test branch 5 times, most recently from 41fd37b to b64a32a Compare December 16, 2024 22:11
@bcorby bcorby changed the title Enable the use of get_option() as a parameter to project() Fix the use of get_option() as a parameter to project() Dec 16, 2024
@bcorby bcorby force-pushed the test branch 4 times, most recently from 955028c to f27a9d6 Compare December 17, 2024 00:30
@bcorby
Copy link
Contributor Author

bcorby commented Dec 17, 2024

I didn’t know where to add the test cases for this so I put them in common. I can move them.

The second commit “Add a feature fixed warning message” isn’t needed for the fix and can be dropped. If its not dropped the meson version that this fix goes in to needs to be confirmed. Its coded as 1.7 at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant