Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d: Fix various linking issues #6090

Merged
merged 2 commits into from
Oct 22, 2019
Merged

d: Fix various linking issues #6090

merged 2 commits into from
Oct 22, 2019

Conversation

GoaLitiuM
Copy link
Contributor

The optlink linker is slowly getting phased out now since DMD ships with the LLVM linker, so it can be used when Visual Studio is not installed.

LLVM and MSVC linker fails to translate get_allow_undefined_args properly which was causing issues, and the last refactor also dropped -shared flag for shared library builds.

The optlink linker is slowly getting phased out now since DMD ships with the LLVM linker, so it can be used when Visual Studio is not installed.
@GoaLitiuM GoaLitiuM changed the title d: Fix various linking issues on Windows d: Fix various linking issues Oct 21, 2019
@jpakkane
Copy link
Member

Should this go in 0.52.1? That is, is the issue in 0.52.0 or did it appear in master after that?

@GoaLitiuM
Copy link
Contributor Author

-shared was broken in 0.52.0, and undefined args in master, this should definitely get fixed in the next point release.

@jpakkane jpakkane added this to the 0.52.1 milestone Oct 22, 2019
@jpakkane jpakkane merged commit dea2c09 into mesonbuild:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants