-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: merge_file() deprecate positional arguments #9445
Conversation
@nirbheek this should go in 0.60 branch but not in master branch IMHO. |
Codecov Report
@@ Coverage Diff @@
## 0.60 #9445 +/- ##
==========================================
- Coverage 68.51% 66.82% -1.70%
==========================================
Files 198 396 +198
Lines 42772 85442 +42670
Branches 8923 17657 +8734
==========================================
+ Hits 29305 57094 +27789
- Misses 11112 23660 +12548
- Partials 2355 4688 +2333
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 999585b into 6ea4e21 - view on LGTM.com new alerts:
|
@eli-schwartz while testing this, I noticed we can do a big simplification in merge_file() code too: #9457. |
Is it just me or does this PR have too many commits? |
It's developed against git master, and when I switched it to merge into the maintenance branch I created, I asked @xclaesse via IRC to rebase a single commit onto the maintenance branch. This has not been done, though it did get rebased onto master again so now it includes even more commits from master. ;) |
Okay, that makes sense. +1 from me to merge this into the 0.60 branch directly once Xavier is satisfied with it (and the rebase is done properly 😉) |
Rebased on 0.60 now. |
They always have been ignored but it became an hard error with no deprecation period in 0.60.0. Since it breaks some GNOME projects, deprecate for now and keep it removed for 0.61.0. Fixes: mesonbuild#9441
Since meson 0.61.0 `i18n.merge_file` no longer accepts positional arguments[1]. [1]: mesonbuild/meson#9445
They always have been ignored but it became an hard error with no
deprecation period in 0.60.0. Since it breaks some GNOME projects,
deprecate for now and keep it removed for 0.61.0.
Fixes #9441