Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimal cargo version #55

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Add minimal cargo version #55

merged 2 commits into from
Jan 9, 2023

Conversation

Ecordonnier
Copy link
Contributor

I am sending this PR with 2 tiny changes.

@Ecordonnier
Add minimal version of rust 1.60
c23a156 
Due to rust-lang/cargo#10623, cargo-bitbake
needs at least cargo 1.60 to be built.
@Ecordonnier
Document dependency in README
3978307
@Ecordonnier Ecordonnier changed the title Eco/cleanup Add minimal cargo version Aug 23, 2022
@Ecordonnier
Copy link
Contributor Author

Ecordonnier commented Jan 9, 2023 •
edited
Loading

@kraj what do you think of this PR? This will cause an error when using an incompatible cargo version and avoid this issue: #54

@kraj
Copy link
Contributor

kraj commented Jan 9, 2023

seems fine to me.

@Ecordonnier
Copy link
Contributor Author

@kraj could you please merge it?

kraj
kraj approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kraj kraj merged commit 77c1f66 into meta-rust:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraj kraj kraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ecordonnier @kraj