Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB-794: Redesign the footer to provide Good UX and be responsive for small screens #1076

Closed
wants to merge 3 commits into from

Conversation

MohamedAli00949
Copy link

Hi there,
I am interested in books and use the Bookbrainz site more times some of them are on my smartphone.

Problem

While I am using a site on my smartphone to learn more about it, I have noticed that it's some of the components aren't responsive for all devices one of these components is the footer so I have opened the BB-794 issue on JIRA and resolved it myself.
As you can see in the following images the footer wasn't responsive with all devices

image-2024-03-04-04-22-09-830
image-2024-03-04-04-22-52-732
image-2024-03-04-04-23-44-862
image-2024-03-04-04-24-35-390

Solution

I have redesigned the footer as you can see in the following images to be responsive and provide a good UX.
Screenshot from 2024-03-12 15-31-52
Screenshot from 2024-03-12 15-33-56
Screenshot from 2024-03-12 15-43-07
Screenshot from 2024-03-12 15-44-16

Areas of Impact

The footer

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry it took me so long to review the PR.

I think some aspects like the padding are a definite improvement over the existing footer, but the alignment in smaller screen sizes doesn't look very good:
image

There is plenty of space on screen, so I'm not so sure why you are aligning everything to the left when wider sizes spread the elements over the whole width.

Happy to help you come up with a design that fits if you want to have another go at the task :)
Do let me know

@MohamedAli00949
Copy link
Author

Thanks @MonkeyDo for this good feedback,
I am interested in improving the design so I hope to show your suggestions.

@MonkeyDo
Copy link
Contributor

Fantastic :)

As a matter of fact, our resident designer has already designed a footer for all the MetaBrainz projects, and we have already implemented it in ListenBrainz for example:
image

The code for that footer can be found here: https://github.com/metabrainz/listenbrainz-server/blob/master/frontend/js/src/components/Footer.tsx

The original design file can be found here. If the design and the ListenBrainz footer don't match, copy LB rather than the design: https://www.figma.com/design/ln8XiFLit634KC3YkUW2RS/MusicBrainz-redesign?node-id=1111-2910&t=wjnUCIUeSXTTcgNR-0

And here is another example of a PR which implements the footer for CritiqueBrainz (using flask rather than react, but in case any css or something is useful): metabrainz/critiquebrainz#491

Let me know if you are up to the task or have any questions ! :)

@MonkeyDo
Copy link
Contributor

MonkeyDo commented Jul 4, 2024

Closing this in favor of a new PR, considering the changes will be different from those in this PR.
See last comment above for some context.

@MonkeyDo MonkeyDo closed this Jul 4, 2024
@MohamedAli00949
Copy link
Author

MohamedAli00949 commented Jul 5, 2024

Closing this in favor of a new PR, considering the changes will be different from those in this PR. See last comment above for some context.

Thanks @MonkeyDo , for your reply my apologies for the late response.
I will show your replay and modify my solution at a new PR the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants