Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CAA provider type selector code to its own file #2312

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Move CAA provider type selector code to its own file #2312

merged 6 commits into from
Sep 14, 2023

Conversation

zas
Copy link
Collaborator

@zas zas commented Sep 13, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

@zas zas force-pushed the caa_split_ui branch 2 times, most recently from 970c15c to 9d26310 Compare September 13, 2023 15:13
zas added 2 commits September 13, 2023 18:03
@zas
Replace CAATypesSelectorDialog.run() static method with module level …
db0ccaf 
…function

New function is named display_caa_types_selector()
All keyword arguments are passed to CAATypesSelectorDialog constructor
@zas
Replace get_selected_types_*() with properties and shorten lines
cfd5753
@zas zas changed the title Caa split UI Move CAA provider type selector code to its own file Sep 13, 2023
@zas zas marked this pull request as ready for review September 14, 2023 08:05
@zas zas requested review from phw and rdswift September 14, 2023 08:05
phw
phw approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move. Code looks good and the dialog works as expected for me.

@zas zas merged commit 1ec3379 into metabrainz:master Sep 14, 2023
@zas zas deleted the caa_split_ui branch September 14, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phw phw phw approved these changes

@rdswift rdswift Awaiting requested review from rdswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zas @phw