-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICARD-1377: New plugin UI icons #2315
Conversation
Once this is implemented, we need to update the images in the documentation at https://picard-docs.musicbrainz.org/en/config/options_plugins.html |
Nice one @phw. How much padding should be in the icon itself was something I wasn’t sure about. |
No strong preference, but I'm fine with cross |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks great! Visually I much prefer the cross, hopefully it doesn’t cause any confusion. |
Summary
Problem
Use the new icons designed by @Aerozol for the plugin UI.
Solution
Set the icons. Also add dark UI detection and use a separate set of icons.
Action
@Aerozol The plugins looks really clean and good. But I think the trash can is a bit small, what do you think? Shall we make that a bit larger?