Metadatabox cleanup #2476

zas · 2024-05-17T12:49:27Z

Summary

This is a…
- Bug fix
- Feature addition
- Refactoring
- Minor / simple change (like a typo)
- Other
Describe this change in 1-2 sentences:

Problem

JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

Update Picard documentation (please include a reference to this PR)
Other (please specify below)

# Conflicts: # picard/ui/metadatabox.py

…list is filtered already

- define methods to use as strings and use getattr()

…p methods

It will make it easier to move code

- alignment never changes, move it outside the loop - set new_item flags once at object creation - it makes the code a bit easier to read imho

- it makes things a bit clearer - it will be easier to add new fields

…he default for dicts

zas · 2024-05-17T21:19:10Z

28d2b17 is a new feature, it will go in another PR if reviews are positive, just a PoC.

EDIT: move to #2478 (based on this branch though)

phw

LGTM, this is working great. Having this merged will also simplify reviewing #2478 (once rebased)

zas requested a review from phw May 17, 2024 13:03

zas force-pushed the metadatabox_cleanup branch from 9395cdb to a78fcdc Compare May 17, 2024 13:44

zas added 10 commits May 17, 2024 16:19

MetadataBox: use self as parent of QtGui.QAction actions

6c83732

lookup_tags() -> _lookup_tags()

e9f90e6

get_file_lookup() -> _get_file_lookup()

bb8091c

open_link() -> _open_link()

74eb110

copy/paste_value() -> _copy/_paste_value()

c945991

update_clipboard() -> _update_clipboard()

385bd3c

edit_tag() -> _edit_tag()

903d3dc

# Conflicts: # picard/ui/metadatabox.py

edit_selected_tag() -> _edit_selected_tag()

a106bc9

toggle_changes_first() -> _toggle_changes_first()

02d191d

set_tag_values() -> _set_tag_values()

d1a9f0d

zas force-pushed the metadatabox_cleanup branch from bfe1a0c to d2f6227 Compare May 17, 2024 14:21

zas added 6 commits May 17, 2024 16:31

remove_tag() -> _remove_tag()

901acc9

tag_is_(removable|editable)() -> _tag_is_(removable|editable)()

8e53ebb

remove_selected_tags(): no need to check if tag is removable, as the …

0396808

…list is filtered already

selected_tags() -> _selected_tags()

888df23

_selected_tags(): make it a generator

7a620f0

set_item_value() -> _set_item_value()

953bdbc

zas force-pushed the metadatabox_cleanup branch from fdd893c to 791b8b2 Compare May 17, 2024 14:31

Drop _lookup_tags() in favor of new _lookup_tag(tag)

94ff51e

- define methods to use as strings and use getattr()

zas force-pushed the metadatabox_cleanup branch from 791b8b2 to 94ff51e Compare May 17, 2024 14:44

zas added 8 commits May 17, 2024 17:11

Test if methods listed in MetadataBox.LOOKUP_TAGS are valid FileLooku…

6a1d568

…p methods

Use named columns instead of numerical values

1d06036

name -> tag (as we iterate among tags)

6157063

Use if/continue instead of filter(lambda...), more readable

6ed7802

Use self.tag_diff after it was set to result

f82c5ac

It will make it easier to move code

Minor code redundancy reduction

43a1103

Consistency: we use tag instead of name everywhere else in the file

4e1ff55

_update_items(): regroup code per column

be261bb

- alignment never changes, move it outside the loop - set new_item flags once at object creation - it makes the code a bit easier to read imho

zas added 4 commits May 17, 2024 19:41

Use a namedtuple for display values, with fields text and is_grouped

138996d

- it makes things a bit clearer - it will be easier to add new fields

different -> is_grouped

a095e31

Add two helper functions to toggle between grouped and normal values

14db96d

Variables orig_tags and new_tags aren't needed, drop keys() as it's t…

72c7c60

…he default for dicts

zas force-pushed the metadatabox_cleanup branch from 28d2b17 to 72c7c60 Compare May 18, 2024 09:07

zas marked this pull request as ready for review May 18, 2024 09:20

zas added the Refactoring label May 18, 2024

phw approved these changes May 19, 2024

View reviewed changes

zas merged commit 38304af into metabrainz:master May 19, 2024
45 checks passed

zas deleted the metadatabox_cleanup branch May 19, 2024 11:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Metadatabox cleanup #2476

Metadatabox cleanup #2476

zas commented May 17, 2024 •

edited

Loading

zas commented May 17, 2024 •

edited

Loading

phw left a comment

Metadatabox cleanup #2476

Metadatabox cleanup #2476

Conversation

zas commented May 17, 2024 • edited Loading

Summary

Problem

Solution

Action

zas commented May 17, 2024 • edited Loading

phw left a comment

Choose a reason for hiding this comment

zas commented May 17, 2024 •

edited

Loading

zas commented May 17, 2024 •

edited

Loading