Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Org Name added Changed it to the new one #508

Closed

Conversation

shaggyyy2002
Copy link
Contributor

@shaggyyy2002 shaggyyy2002 commented Jun 15, 2024

Description

Wrong Org Name added Changed it to the new one on line 77

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests/screenshots (if any) that prove my fix is effective or that my feature works.
  • I have tested the tests implicated (if any) by my own code and they pass (make test or ctest -VV -R <test-name>).
  • If my change is significant or breaking, I have passed all tests with ./docker-compose.sh test &> output and attached the output.
  • I have tested my code with OPTION_BUILD_ADDRESS_SANITIZER or ./docker-compose.sh test-address-sanitizer &> output and OPTION_TEST_MEMORYCHECK.
  • I have tested my code with OPTION_BUILD_THREAD_SANITIZER or ./docker-compose.sh test-thread-sanitizer &> output.
  • I have tested with Helgrind in case my code works with threading.
  • I have run make clang-format in order to format my code and my code follows the style guidelines.

If you are unclear about any of the above checks, have a look at our documentation here.

In this I have added the repository dispatch so that it will trigger the windows-dist repo, only if it passes all the windows tests mentioned
some minor changes on line 77
@viferga
Copy link
Member

viferga commented Jun 17, 2024

You can push to the same branch and this will be added to the other PR.

@viferga
Copy link
Member

viferga commented Jun 19, 2024

Duplicated.

@viferga viferga closed this Jun 19, 2024
@shaggyyy2002 shaggyyy2002 deleted the shaggyyy2002-windowsCI-1 branch June 20, 2024 21:06
@shaggyyy2002 shaggyyy2002 restored the shaggyyy2002-windowsCI-1 branch June 20, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants