Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the new Rust port #529

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

hulxv
Copy link
Contributor

@hulxv hulxv commented Nov 1, 2024

Description

This pull request introduces the new version of the Rust port for MetaCall, with enhancements, and performance improvements aimed at better integration and usability within the Rust ecosystem.

@viferga viferga marked this pull request as draft November 1, 2024 16:29
@hulxv hulxv changed the title Introduce new rust version Introduce the new Rust port Nov 1, 2024
@viferga viferga closed this Nov 22, 2024
@viferga
Copy link
Member

viferga commented Nov 22, 2024

@hulxv can you verify you can push here? #534

If not, I can give you access.

@hulxv
Copy link
Contributor Author

hulxv commented Nov 22, 2024

@hulxv can you verify you can push here? #534

If not, I can give you access.

No, I can't

@viferga viferga reopened this Nov 22, 2024
@viferga viferga marked this pull request as ready for review November 22, 2024 14:53
@viferga
Copy link
Member

viferga commented Nov 22, 2024

@hulxv I am reopening this one then.

@viferga viferga marked this pull request as draft November 22, 2024 14:54
- implement a constructor and `get_value` for
  - i16, i32, i64
  - f32, f64
  - String, &str
- implement those methods for Value<T>:
  - `is_null()`
  - `value_id()`
  - `value_id_name()`
**Error message:**
```
  thread 'value::test::metacall_create_value_str' panicked at src/value/mod.rs:96:9:
    assertion `left == right` failed
        left: "Hello!\"\u{7}"
        right: "Hello!"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants