Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve metassr build with docs and tests #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

test(builder):: add test-cases to `metassr-build::manifest`

ad83df3
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

improve metassr build with docs and tests #23

test(builder):: add test-cases to `metassr-build::manifest`
ad83df3
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Sep 21, 2024 in 1s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 66 in metassr-cli/src/cli/builder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
  --> metassr-cli/src/cli/builder.rs:66:1
   |
66 | impl Into<server::BuildingType> for BuildingType {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
           https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
   = note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<cli::builder::BuildingType>`
   |
66 ~ impl From<BuildingType> for server::BuildingType {
67 ~     fn from(val: BuildingType) -> Self {
68 ~         match val {
69 ~             BuildingType::SSG => server::BuildingType::StaticSiteGeneration,
70 ~             BuildingType::SSR => server::BuildingType::ServerSideRendering,
   |

Check warning on line 63 in metassr-cli/src/cli/builder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

name `SSR` contains a capitalized acronym

warning: name `SSR` contains a capitalized acronym
  --> metassr-cli/src/cli/builder.rs:63:5
   |
63 |     SSR,
   |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Ssr`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms

Check warning on line 61 in metassr-cli/src/cli/builder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

name `SSG` contains a capitalized acronym

warning: name `SSG` contains a capitalized acronym
  --> metassr-cli/src/cli/builder.rs:61:5
   |
61 |     SSG,
   |     ^^^ help: consider making the acronym lowercase, except the initial letter: `Ssg`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms
   = note: `#[warn(clippy::upper_case_acronyms)]` on by default

Check warning on line 49 in crates/metassr-server/src/handler.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `path`

warning: unused variable: `path`
  --> crates/metassr-server/src/handler.rs:49:28
   |
49 |                       Path(path): Path<HashMap<String, String>>| async move {
   |                            ^^^^ help: if this is intentional, prefix it with an underscore: `_path`

Check warning on line 48 in crates/metassr-server/src/handler.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `params`

warning: unused variable: `params`
  --> crates/metassr-server/src/handler.rs:48:29
   |
48 |                 move |Query(params): Query<HashMap<String, String>>,
   |                             ^^^^^^ help: if this is intentional, prefix it with an underscore: `_params`
   |
   = note: `#[warn(unused_variables)]` on by default

Check warning on line 28 in crates/metassr-create/src/templates.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

direct implementation of `ToString`

warning: direct implementation of `ToString`
  --> crates/metassr-create/src/templates.rs:20:1
   |
20 | / impl ToString for Template {
21 | |     fn to_string(&self) -> String {
22 | |         match *self {
23 | |             Self::Javascript => "javascript",
...  |
27 | |     }
28 | | }
   | |_^
   |
   = help: prefer implementing `Display` instead
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
   = note: `#[warn(clippy::to_string_trait_impl)]` on by default

Check warning on line 96 in crates/metassr-utils/src/rand.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

re-implementing `PartialEq::ne` is unnecessary

warning: re-implementing `PartialEq::ne` is unnecessary
  --> crates/metassr-utils/src/rand.rs:94:5
   |
94 | /     fn ne(&self, other: &i64) -> bool {
95 | |         &self.0 != other
96 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl

Check warning on line 68 in crates/metassr-utils/src/rand.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

re-implementing `PartialEq::ne` is unnecessary

warning: re-implementing `PartialEq::ne` is unnecessary
  --> crates/metassr-utils/src/rand.rs:66:5
   |
66 | /     fn ne(&self, other: &Self) -> bool {
67 | |         self.0 != other.0
68 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl
   = note: `#[warn(clippy::partialeq_ne_impl)]` on by default

Check warning on line 39 in crates/metassr-utils/src/rand.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you should consider adding a `Default` implementation for `Rand`

warning: you should consider adding a `Default` implementation for `Rand`
  --> crates/metassr-utils/src/rand.rs:36:5
   |
36 | /     pub fn new() -> Self {
37 | |         let val = RandomState::new().build_hasher().finish() as i64; // Generate a random value
38 | |         Self(val.abs()) // Ensure the value is non-negative
39 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
   = note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
   |
23 + impl Default for Rand {
24 +     fn default() -> Self {
25 +         Self::new()
26 +     }
27 + }
   |

Check warning on line 19 in crates/html-generator/src/html_props.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods called `new` usually return `Self`

warning: methods called `new` usually return `Self`
  --> crates/html-generator/src/html_props.rs:17:5
   |
17 | /     pub fn new() -> HtmlPropsBuilder {
18 | |         HtmlPropsBuilder::new()
19 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
   = note: `#[warn(clippy::new_ret_no_self)]` on by default

Check warning on line 30 in crates/html-generator/src/builder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

direct implementation of `ToString`

warning: direct implementation of `ToString`
  --> crates/html-generator/src/builder.rs:26:1
   |
26 | / impl ToString for HtmlOutput {
27 | |     fn to_string(&self) -> String {
28 | |         self.0.clone()
29 | |     }
30 | | }
   | |_^
   |
   = help: prefer implementing `Display` instead
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl
   = note: `#[warn(clippy::to_string_trait_impl)]` on by default