Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metafix.java #370

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Update Metafix.java #370

merged 3 commits into from
Oct 14, 2024

Conversation

TobiasNx
Copy link
Collaborator

@TobiasNx TobiasNx commented Sep 27, 2024

Add signature and description. The fix modul was missing this. @fsteeg I am not sure why this fails?

Add signature and description
@fsteeg
Copy link
Member

fsteeg commented Sep 27, 2024

The annotations (starting with @) need to be imported, see top of other modules. Your IDE should make this easy (should complain at the lines where the annotations are used, offering help, something like "Add missing imports", "Organize imports").

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Sep 27, 2024
@TobiasNx TobiasNx assigned fsteeg and unassigned TobiasNx Oct 9, 2024
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor inline suggestions.

@fsteeg fsteeg assigned TobiasNx and unassigned fsteeg Oct 10, 2024
Review by @fsteeg #370

Co-authored-by: Fabian Steeg <steeg@hbz-nrw.de>
@TobiasNx TobiasNx merged commit 4453635 into master Oct 14, 2024
1 check passed
@TobiasNx TobiasNx deleted the add-signature-and-description branch October 14, 2024 12:52
@Description("Applies a fix transformation to the event stream, given as the path to a fix file or the fixes themselves.") // checkstyle-disable-line ClassDataAbstractionCoupling|ClassFanOutComplexity
@In(StreamReceiver.class)
@Out(StreamReceiver.class)
@FluxCommand("fix")
public class Metafix implements StreamPipe<StreamReceiver>, Maps { // checkstyle-disable-line ClassDataAbstractionCoupling
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Checkstyle comment is superseded by the one above.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I fix this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants