Port OS Environment varialbes to viper config #127
Conversation
| bucket: | ||
| access_key: | ||
| secret_key: | ||
| s3: |
There was a problem hiding this comment.
What's the difference between the s3 and asrr.s3 stanzas?
There was a problem hiding this comment.
@DoctorVin s3 is the destination bucket. asrr s3 is the source bucket for AsRockrack firmware images. It's a hack because our firmware images for ASRR come from a ftp site that's not available publicly so at the time this was added we agreed to keep the fw images in that s3 bucket and sync from there instead of using the private ftp they provide.
| err := v.ReadInConfig() | ||
|
|
||
| if err != nil { | ||
| logger.Error("Failed to find viper config file") |
| @@ -67,7 +77,7 @@ func New(configFile string, logLevel int) (*Syncer, error) { | |||
| case common.VendorDell: | |||
| var dup vendors.Vendor | |||
|
|
|||
| dup, err = dell.NewDUP(context.TODO(), firmwares, cfgSyncer, logger) | |||
| dup, err = dell.NewDUP(context.TODO(), firmwares, cfgSyncer, logger, v) | |||
There was a problem hiding this comment.
instead of passing the viper pointer, it would be nicer (IMO) to parse this into one (or several?) structs that were specific to the vendors?
|
@jakeschuurmans In branch https://github.com/metal-toolbox/firmware-syncer/tree/on-demand-sync I have the changes to align the env variable handling in the firmware-syncer with the metal-toolbox. Unfortunately it's a bit of a mess as I was cargo culting things over from flasher/cookie-flipper to get the on-demand syncing working and I pulled in the env var handling as well. Maybe it could help you and address some of Vince's comments. |
|
Is this still a work in progress? |
No description provided.