outofband/actions: when required reset BMC during polling

To reset or not is determined by the bmclib provider, which is set on
the Action when the firmware install is planned.

internal/outofband/action_handlers.go

@@ -702,6 +702,24 @@ func (h *actionHandler) pollFirmwareTaskStatus(a sw.StateSwitch, c sw.Transition
 				)
 			}
 
+			// A BMC reset is required if the BMC install fails - to get it out of flash mode
+			if componentIsBMC(action.Firmware.Component) && action.BMCResetOnInstallFailure {
+				if err := h.powerCycleBMC(tctx); err != nil {
+					tctx.Logger.WithFields(
+						logrus.Fields{
+							"bmc":       tctx.Asset.BmcAddress,
+							"component": action.Firmware.Component,
+							"err":       err.Error(),
+						}).Debug("install failure required a BMC reset, reset returned error")
+				}
+
+				tctx.Logger.WithFields(
+					logrus.Fields{
+						"bmc":       tctx.Asset.BmcAddress,
+						"component": action.Firmware.Component,
+					}).Debug("BMC reset for failed BMC firmware install")
+			}
+
 			return errors.Wrap(ErrFirmwareInstallFailed, errMsg)
 
 		// return nil when install is complete
@@ -711,6 +729,23 @@ func (h *actionHandler) pollFirmwareTaskStatus(a sw.StateSwitch, c sw.Transition
 			if componentIsBMC(action.Firmware.Component) {
 				inventory = true
 
+				if action.BMCResetPostInstall {
+					if errBmcReset := h.powerCycleBMC(tctx); errBmcReset != nil {
+						tctx.Logger.WithFields(
+							logrus.Fields{
+								"bmc":       tctx.Asset.BmcAddress,
+								"component": action.Firmware.Component,
+								"err":       errBmcReset.Error(),
+							}).Debug("install success required a BMC reset, reset returned error")
+					}
+
+					tctx.Logger.WithFields(
+						logrus.Fields{
+							"bmc":       tctx.Asset.BmcAddress,
+							"component": action.Firmware.Component,
+						}).Debug("BMC reset for successful BMC firmware install")
+				}
+
 				continue
 			}
 

internal/outofband/actions.go

@@ -148,6 +148,12 @@ func convFirmwareInstallSteps(required []bconsts.FirmwareInstallStep, defined Tr
 	transitions := Transitions{}
 
 	for _, s := range required {
+		// TODO: turn FirmwareInstalSteps into FirmwareInstallProperties with fields for these non step parameters
+		if s == bconsts.FirmwareInstallStepResetBMCOnInstallFailure ||
+			s == bconsts.FirmwareInstallStepResetBMCPostInstall {
+			continue
+		}
+
 		transitionName, exists := m[s]
 		if !exists {
 			return nil, errors.Wrap(errUnsupported, string(s))