purge unused Task.InstallFirmwares field

metal-toolbox · May 4, 2023 · 5649a62 · 5649a62
1 parent 4c09777
commit 5649a62
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 18 deletions.
diff --git a/internal/model/task.go b/internal/model/task.go
@@ -126,9 +126,6 @@ type Task struct {
 	// these are generated in the `pending` stage of the task.
 	ActionsPlanned Actions
 
-	// InstallFirmwares is the list of firmware planned for install.
-	InstallFirmwares []*Firmware
-
 	// Parameters for this task
 	Parameters TaskParameters
 

diff --git a/internal/outofband/actions_test.go b/internal/outofband/actions_test.go
@@ -20,7 +20,6 @@ import (
 func newTaskFixture(status string) *model.Task {
 	task := &model.Task{}
 	task.Status = string(status)
-	task.InstallFirmwares = fixtures.Firmware
 
 	// task.Parameters.Device =
 	return task
@@ -116,9 +115,6 @@ func Test_ActionStateMachine_Run_Succeeds(t *testing.T) {
 	firmware[0].Checksum = blobChecksum
 	firmware[0].FileName = "dummy.bin"
 
-	// set firmware planned for install
-	task.InstallFirmwares = []*model.Firmware{firmware[0]}
-
 	action := model.Action{
 		ID:       "foobar",
 		TaskID:   task.ID.String(),
@@ -180,9 +176,6 @@ func Test_ActionStateMachine_Run_Fails(t *testing.T) {
 	firmware[0].Checksum = blobChecksum
 	firmware[0].FileName = "dummy.bin"
 
-	// set firmware planned for install
-	task.InstallFirmwares = []*model.Firmware{firmware[0]}
-
 	action := model.Action{
 		ID:       "foobar",
 		TaskID:   task.ID.String(),

diff --git a/internal/statemachine/task_test.go b/internal/statemachine/task_test.go
@@ -66,7 +66,6 @@ func newTaskFixture(t *testing.T, state string) *model.Task {
 		t.Fatal(err)
 	}
 
-	task.InstallFirmwares = firmwares
 	task.Parameters.AssetID = asset1
 
 	return task

diff --git a/internal/worker/task_handler.go b/internal/worker/task_handler.go
@@ -90,10 +90,6 @@ func (h *taskHandler) ValidatePlan(t sw.StateSwitch, args sw.TransitionArgs) (bo
 		return false, errors.Wrap(ErrSaveTask, ErrTaskTypeAssertion.Error())
 	}
 
-	if len(task.InstallFirmwares) == 0 {
-		return false, errors.Wrap(errTaskPlanValidate, "no firmwares planned for install")
-	}
-
 	// validate task has action plans listed
 	if len(task.ActionsPlanned) == 0 {
 		return false, errors.Wrap(errTaskPlanValidate, "no task actions planned")
@@ -278,9 +274,6 @@ func (h *taskHandler) planInstall(_ *sm.HandlerContext, task *model.Task, firmwa
 		// include action state machines that will be executed.
 		actionMachines = append(actionMachines, m)
 
-		// include applicable firmware in planned
-		task.InstallFirmwares = append(task.InstallFirmwares, firmwares[idx])
-
 		newAction := model.Action{
 			ID:     actionID,
 			TaskID: task.ID.String(),