Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approver group validity check #109

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jacobsee
Copy link
Contributor

@jacobsee jacobsee commented Mar 26, 2024

Ensure that the approver group is set before attempting to count the members to see if a membership request should fall back to the Governor global admins or not. This codepath is only hit when a membership request is made to an empty group.

…members to see if an approval request should fall back to the Governor global admins or not. This codepath is only hit when a membership request is made to an empty group.
@jacobsee jacobsee requested a review from a team as a code owner March 26, 2024 17:05
Copy link
Contributor

@bailinhe bailinhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jacobsee jacobsee merged commit 0b0d94e into metal-toolbox:main Mar 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants