Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get/add/update/remove hierarchical groups #20

Merged
merged 5 commits into from
Jul 31, 2023
Merged

Get/add/update/remove hierarchical groups #20

merged 5 commits into from
Jul 31, 2023

Conversation

jacobsee
Copy link
Contributor

@jacobsee jacobsee commented Jul 26, 2023 •
edited
Loading

Does not allow hierarchical groups to form a cycle (incl. self-membership), emits NATS events for effective group membership changes.

@jacobsee jacobsee marked this pull request as ready for review July 26, 2023 01:08
@jacobsee jacobsee requested a review from a team as a code owner July 26, 2023 01:08
@jacobsee jacobsee changed the title Add/update/remove hierarchical groups Get/add/update/remove hierarchical groups Jul 26, 2023
tenyo
tenyo approved these changes Jul 27, 2023
View reviewed changes
Copy link

@tenyo tenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a cool new feature 👍

@jacobsee jacobsee merged commit 38c4eab into metal-toolbox:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenyo tenyo tenyo approved these changes

@fishnix fishnix fishnix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobsee @fishnix @tenyo