Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User and group endpoints should return info about direct membership #25

Merged
merged 3 commits into from
Aug 3, 2023
Merged

User and group endpoints should return info about direct membership #25

merged 3 commits into from
Aug 3, 2023

Conversation

jacobsee
Copy link
Contributor

@jacobsee jacobsee commented Aug 2, 2023

not just all enumerated membership

@jacobsee jacobsee requested a review from a team as a code owner August 2, 2023 22:01
jnschaeffer
jnschaeffer reviewed Aug 3, 2023
View reviewed changes
Copy link

@jnschaeffer jnschaeffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment here.

pkg/api/v1alpha1/authenticated_user.go Outdated Show resolved Hide resolved
@jacobsee jacobsee requested a review from jnschaeffer August 3, 2023 16:22
fishnix
fishnix reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@fishnix fishnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a bunch of places where we don't use named struct properties when initializing a struct - I wonder if you should either fix those or revert the one you fixed and fix them all as a separate body of work b/c now they're not consistent?

@jacobsee jacobsee merged commit b35d2fe into metal-toolbox:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishnix fishnix fishnix approved these changes

@jnschaeffer jnschaeffer Awaiting requested review from jnschaeffer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobsee @fishnix @jnschaeffer