Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial API implementation of admin elevation request and expiration #56

Merged
merged 6 commits into from
Sep 19, 2023
Merged

initial API implementation of admin elevation request and expiration #56

merged 6 commits into from
Sep 19, 2023

Conversation

jacobsee
Copy link
Contributor

(expiration to be handled by core addon)

UI, core addon, notification addon PRs incoming.

@jacobsee jacobsee requested a review from a team as a code owner September 16, 2023 04:32
@jacobsee jacobsee marked this pull request as draft September 16, 2023 04:33
@jacobsee jacobsee marked this pull request as ready for review September 18, 2023 20:49
fishnix
fishnix reviewed Sep 18, 2023
View reviewed changes
Copy link
Contributor

@fishnix fishnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in general - I had a couple of comments. 👍

db/migrations/00033_group_request_types.sql Show resolved Hide resolved
internal/dbtools/hooks.go Outdated Show resolved Hide resolved
db/migrations/00033_group_request_types.sql Outdated Show resolved Hide resolved
pkg/events/v1alpha1/events.go Outdated Show resolved Hide resolved
@jacobsee jacobsee merged commit aaca8c0 into metal-toolbox:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishnix fishnix fishnix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobsee @fishnix