Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Extend Governor APIs] System Extension Resources #75

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[Extend Governor APIs] System Extension Resources #75

merged 3 commits into from
Oct 19, 2023

Conversation

bailinhe
Copy link
Contributor

@bailinhe bailinhe commented Oct 4, 2023

Operation Method URI
list GET /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>
create POST /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>
get GET /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>/<er-slug-or-id>
update PATCH /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>/<er-slug-or-id>
delete DELETE /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>/<er-slug-or-id>

@bailinhe bailinhe force-pushed the extend-governor-apis/system-extension-resources branch from f20395a to 014423d Compare October 6, 2023 19:04
@bailinhe bailinhe force-pushed the extend-governor-apis/system-extension-resources branch from 014423d to d528dce Compare October 18, 2023 16:48
@bailinhe bailinhe marked this pull request as ready for review October 18, 2023 16:52
@bailinhe bailinhe requested a review from a team as a code owner October 18, 2023 16:52
fishnix
fishnix previously approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@fishnix fishnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for @jacobsee 's comment, this lgtm 👍

@bailinhe @jacobsee
Update pkg/api/v1alpha1/sys_extension_resources.go
d751238 
Co-authored-by: Jacob See <5027680+jacobsee@users.noreply.github.com>
@bailinhe
Copy link
Contributor Author

thanks to @jacobsee's suggestions, I fixed the problem where I need the user to put in double quotes in the URI queries, as a plus benefit, I don't need to manually add double quotes to the SQL queries in the JSON validator. Should've read postgres docs instead of the CRDB docs

@bailinhe bailinhe merged commit c7f0dd4 into metal-toolbox:main Oct 19, 2023
@bailinhe bailinhe deleted the extend-governor-apis/system-extension-resources branch October 19, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsee jacobsee jacobsee approved these changes

@fishnix fishnix fishnix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bailinhe @fishnix @jacobsee