Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Extend Governor APIs] User Extension Resources #86

Merged
merged 2 commits into from
Oct 20, 2023
Merged

[Extend Governor APIs] User Extension Resources #86

merged 2 commits into from
Oct 20, 2023

Conversation

bailinhe
Copy link
Contributor

User Resources

Prefixes

  • authenticated user resources: /api/v1alpha1/user/extension-resources
  • admin managing user resources: /api/v1alpha1/users/:user-id/extension-resources

URIs

Operation Method URI
list GET /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>
create POST /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>
get GET /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>/<er-slug-or-id>
update PATCH /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>/<er-slug-or-id>
delete DELETE /<prefix>/<extension-slug>/<erd-slug-plural>/<erd-version>/<er-slug-or-id>

@bailinhe
add user extension resources
3ad2836 
add audits and events

add tests

add user extension resource client

add user extension resource client
@bailinhe bailinhe marked this pull request as ready for review October 20, 2023 17:26
@bailinhe bailinhe requested a review from a team as a code owner October 20, 2023 17:26
jacobsee
jacobsee previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@jacobsee jacobsee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just spotted one typo in an error string but 👍

pkg/api/v1alpha1/errors.go Outdated Show resolved Hide resolved
@bailinhe @jacobsee
Update pkg/api/v1alpha1/errors.go
54db613 
Co-authored-by: Jacob See <5027680+jacobsee@users.noreply.github.com>
@bailinhe bailinhe merged commit 1e70e41 into metal-toolbox:main Oct 20, 2023
@bailinhe bailinhe deleted the extend-governor-apis/user-extension-resources branch October 23, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsee jacobsee jacobsee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bailinhe @jacobsee