Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension resource lifecycle #99

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Extension resource lifecycle #99

merged 3 commits into from
Jan 30, 2024

Conversation

bailinhe
Copy link
Contributor

@bailinhe bailinhe commented Jan 22, 2024 •
edited
Loading

Add a middleware on extension routes to:

  • reject any update/create/delete on extension resources whose extension or ERD is disabled
  • use gin.Context to cache the DB query results throughout a request to reduce duplicate queries

@bailinhe bailinhe force-pushed the mid-184/extension-life-cycle branch from 5e106e0 to 14859f7 Compare January 22, 2024 15:38
@bailinhe bailinhe marked this pull request as ready for review January 23, 2024 17:06
@bailinhe bailinhe requested a review from a team as a code owner January 23, 2024 17:06
@bailinhe bailinhe merged commit 745eb9c into metal-toolbox:main Jan 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsee jacobsee jacobsee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bailinhe @jacobsee