Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events/nats: Update consumer configuration when a consumer exists #148

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

joelrebel
Copy link
Member

Updates a consumer configuration if a consumer exists.
Adds tests for consumer add/update.

@joelrebel joelrebel requested review from a team as code owners July 19, 2023 13:22
Copy link
Collaborator

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK, but I am concerned about some of the edge cases.

events/nats.go Outdated Show resolved Hide resolved
events/nats.go Show resolved Hide resolved
events/nats.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #148 (dd9e74b) into main (575e936) will decrease coverage by 1.05%.
The diff coverage is 26.47%.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   68.03%   66.99%   -1.05%     
==========================================
  Files          17       17              
  Lines         998     1027      +29     
==========================================
+ Hits          679      688       +9     
- Misses        267      286      +19     
- Partials       52       53       +1     
Flag Coverage Δ
unittests 66.99% <26.47%> (-1.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
events/nats.go 39.51% <26.47%> (-1.13%) ⬇️

@joelrebel joelrebel merged commit 6e778f6 into main Jul 20, 2023
@joelrebel joelrebel deleted the nats-consumer-update branch July 20, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants