Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ginjwt/Validate config #206

Merged
merged 3 commits into from
Mar 27, 2024
Merged

ginjwt/Validate config #206

merged 3 commits into from
Mar 27, 2024

Conversation

joelrebel
Copy link
Member

  • Validate multitoken configuration, when creating a new instance, instead of returning as is.
  • Validate required Audience, Issuer fields.

This prevents callers from misconfiguring their services, by enforcing the configuration requirements.

@joelrebel joelrebel requested review from a team as code owners March 27, 2024 10:10
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 66.92%. Comparing base (6d1c821) to head (252ab4f).

Files Patch % Lines
ginjwt/multitokenmiddleware.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   66.92%   66.92%   -0.01%     
==========================================
  Files          17       17              
  Lines        1028     1037       +9     
==========================================
+ Hits          688      694       +6     
- Misses        287      290       +3     
  Partials       53       53              
Flag Coverage Δ
unittests 66.92% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelrebel joelrebel merged commit ca363be into main Mar 27, 2024
2 of 4 checks passed
@joelrebel joelrebel deleted the ginjwt-config branch March 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants