-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: comment syntax godoc-compatible #54
Conversation
@jabielecki could you sign your commit using gitsign? After installing it, you could follow the instructions to enable it for this repository:
|
The godoc and pkg.go.dev do not use Markdown and do not understand asterix nor backtick. With this change, documentation renders correctly. Adding a badge to the README, so that it would be easy to get the dev's documentation when visiting GitHub with just a browser.
Hmm. My commit previously had a perfectly valid SSH-based signature and was green When I changed to gitsign signature and force-pushed here, it become
Then I've decided to author with the same email (which was cumbersome operation, but in the end doable). The new signature changed nothing.
|
@jabielecki it's actually OK if it's |
@jabielecki so... I managed to mess up the chainguard enforce configuration. Here's the fix: #55 However, after pulling your PR, I can verify that it's you 😄 : $ git verify-commit HEAD
tlog index: 4555150
gitsign: Signature made using certificate ID 0xb37b5902cbabcf206138213ebaa4d4e370f29264 | CN=sigstore-intermediate,O=sigstore.dev
gitsign: Good signature from [jakub.bielecki@codilime.com]
Validated Git signature: true
Validated Rekor entry: true |
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 73.81% 73.81%
=======================================
Files 10 10
Lines 550 550
=======================================
Hits 406 406
Misses 115 115
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@JAORMX Thank you, sir. The effect of this PR will become visible after next semver tag, e.g. |
The godoc and pkg.go.dev do not use Markdown and do not understand asterix nor backtick. With this change it renders correctly.
Adding a badge to the README, so that it would be easy to get the dev's docs when visiting GitHub with just a browser.