Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common functions found in hollow root commands #60

Merged
merged 10 commits into from
Oct 14, 2022

Conversation

andy-v-h
Copy link
Contributor

I'm a little tired of copy-pasting these, so let's generalize them.

@andy-v-h andy-v-h requested a review from a team October 13, 2022 18:46
@andy-v-h andy-v-h force-pushed the feat/root-command-helpers branch 5 times, most recently from 563be3c to 0a9b43d Compare October 13, 2022 19:10
Signed-off-by: Andrew Holtzmann <github@dope.email>
@andy-v-h andy-v-h force-pushed the feat/root-command-helpers branch from 0a9b43d to f2c01c4 Compare October 13, 2022 19:30
@andy-v-h andy-v-h changed the title Add common functions ffound in hollow root commands Add common functions found in hollow root commands Oct 13, 2022
Signed-off-by: Andrew Holtzmann <github@dope.email>
Signed-off-by: Andrew Holtzmann <github@dope.email>
Signed-off-by: Andrew Holtzmann <github@dope.email>
Signed-off-by: Andrew Holtzmann <github@dope.email>
@codecov-commenter
Copy link

Codecov Report

Merging #60 (aa445f1) into main (72a217b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   73.81%   73.81%           
=======================================
  Files          10       10           
  Lines         550      550           
=======================================
  Hits          406      406           
  Misses        115      115           
  Partials       29       29           
Flag Coverage Δ
unittests 73.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ginjwt/helpers.go 79.01% <ø> (ø)
ginauth/remote.go 76.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andy-v-h andy-v-h merged commit f5ee08d into metal-toolbox:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants