Respect passed-in Viper instance in helper utility #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `RegisterViperOIDCFlags`, the `Viper` instance wasn't being respected. Instead the underlying function used the global instance... which is fine in most cases, but is not what was requested by the library user. This instead fixes that by actually using a function to bind the flag to a viper instance using the given instance. The previously used bind function is kept to ensure backwards compatibility with applications that might still be using it. Signed-off-by: Juan Antonio Osorio <juan.osoriorobles@eu.equinix.com>
sfunkhouser
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
RegisterViperOIDCFlags, theViperinstance wasn't beingrespected. Instead the underlying function used the global instance...
which is fine in most cases, but is not what was requested by the
library user.
This instead fixes that by actually using a function to bind the flag to
a viper instance using the given instance. The previously used bind
function is kept to ensure backwards compatibility with applications
that might still be using it.
Closes #43
Signed-off-by: Juan Antonio Osorio juan.osoriorobles@eu.equinix.com