Add support for hdparm based drive wipe #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
requested review from
joelrebel,
splaspood,
turegano-equinix and
DoctorVin
as code owners
mmlb
force-pushed
the
crypto-scramble-based-wipes-for-sed-drives
branch
3 times, most recently
from
3079cb4 to
ef4f73c
Compare
Similar to what we're doing for NVME devices, this command supports Sanitizing and Erasing and decides which function and parameters to use depending on the capabilities reported by the drive. Sanitize is preferred over erase. Cryptographic scramble is preferred of block erase within Sanitize. I reused the nvme sanitize/erase type since utils is all one big package anyway to avoid confusion. If we ever split each utility into its own package (as I want) then we'll just create a more specific type for hdparm.
mmlb
force-pushed
the
crypto-scramble-based-wipes-for-sed-drives
branch
from
341bc2e to
b39e610
Compare
mmlb
force-pushed
the
crypto-scramble-based-wipes-for-sed-drives
branch
from
6273469 to
42f0690
Compare
joelrebel
reviewed
Jul 9, 2024
joelrebel
approved these changes
Jul 9, 2024
mmlb
referenced
this pull request
in metal-toolbox/vogelkop
Jul 9, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/metal-toolbox/ironlib](https://github.com/metal-toolbox/ironlib) | `v0.3.0` -> `v0.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>metal-toolbox/ironlib (github.com/metal-toolbox/ironlib)</summary> ### [`v0.4.0`](https://github.com/metal-toolbox/ironlib/releases/tag/v0.4.0) [Compare Source](https://github.com/metal-toolbox/ironlib/compare/v0.3.0...v0.4.0) #### What's Changed - Update module golang.org/x/net to v0.26.0 by [@​renovate](https://github.com/renovate) in [https://github.com/metal-toolbox/ironlib/pull/162](https://github.com/metal-toolbox/ironlib/pull/162) - Update module github.com/beevik/etree to v1.4.0 by [@​renovate](https://github.com/renovate) in [https://github.com/metal-toolbox/ironlib/pull/155](https://github.com/metal-toolbox/ironlib/pull/155) - Update anchore/sbom-action action to v0.16.0 by [@​renovate](https://github.com/renovate) in [https://github.com/metal-toolbox/ironlib/pull/156](https://github.com/metal-toolbox/ironlib/pull/156) - Update docker/build-push-action action to v6 by [@​renovate](https://github.com/renovate) in [https://github.com/metal-toolbox/ironlib/pull/164](https://github.com/metal-toolbox/ironlib/pull/164) - Add support for hdparm based drive wipe by [@​mmlb](https://github.com/mmlb) in [https://github.com/metal-toolbox/ironlib/pull/167](https://github.com/metal-toolbox/ironlib/pull/167) - Change Info log messages by [@​mmlb](https://github.com/mmlb) in [https://github.com/metal-toolbox/ironlib/pull/169](https://github.com/metal-toolbox/ironlib/pull/169) **Full Changelog**: metal-toolbox/ironlib@v0.3.0...v0.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/metal-toolbox/vogelkop). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Similar to what we're doing for NVME devices, this command supports
Sanitizing and Erasing and decides which function and parameters to use
depending on the capabilities reported by the drive.
Sanitize is preferred over erase. Cryptographic scramble is preferred of
block erase within Sanitize.
I reused the nvme sanitize/erase type since utils is all one big package
anyway to avoid confusion. If we ever split each utility into its own
package (as I want) then we'll just create a more specific type for
hdparm.