Common types #47
Merged
Common types #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common.Device type is provided by github.com/bmc-toolbox/common the ironlib device and components are now of the common.Device underlying type. The changes included updates all Device, Component types and Slug constants to work with the common types and constants. Any tooling that now builds on top ironlib, bmclib can work with a consistent set of Device, Component, Firmware types and Slug constants. This means theres less work need to be done to transform between types from both the libraries, and compare slugs/constants.
diogomatsubara
requested changes
Jun 17, 2022
diogomatsubara
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
The common.Device type is provided by https://github.com/bmc-toolbox/common
the ironlib device and components are now of the common.Device underlying type.
The changes included updates all Device, Component types and Slug
constants to work with the common types and constants.
Any tooling that now builds on top ironlib (and bmclib)
can work with a consistent (common) set of Device, Component, Firmware types and
Slug constants. This means theres less work needed to be done to transform
between types from both the libraries, and compare slugs/constants.